Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grafanaplane): add high-level OnCall interface #20

Merged
merged 37 commits into from
Jan 6, 2025

Conversation

alexander-bauer
Copy link
Contributor

@alexander-bauer alexander-bauer commented Dec 27, 2024

This PR adds a high-level interface as a subpackage oncall for emitting Grafana OnCall resources. This package provides the following resources:

@CLAassistant
Copy link

CLAassistant commented Dec 27, 2024

CLA assistant check
All committers have signed the CLA.

@alexander-bauer
Copy link
Contributor Author

I think that we can push adding coverage for OutgoingWebhook and UserNotificationRule until a future release.

@alexander-bauer alexander-bauer marked this pull request as ready for review December 30, 2024 21:11
@alexander-bauer alexander-bauer requested a review from a team as a code owner December 30, 2024 21:11
grafanaplane/oncall/escalation.libsonnet Outdated Show resolved Hide resolved
grafanaplane/oncall/escalation.libsonnet Outdated Show resolved Hide resolved
grafanaplane/oncall/escalationchain.libsonnet Outdated Show resolved Hide resolved
grafanaplane/oncall/escalationchain.libsonnet Outdated Show resolved Hide resolved
grafanaplane/util.libsonnet Outdated Show resolved Hide resolved
grafanaplane/oncall/shift.libsonnet Outdated Show resolved Hide resolved
grafanaplane/oncall/integration.libsonnet Outdated Show resolved Hide resolved
grafanaplane/oncall/schedule.libsonnet Outdated Show resolved Hide resolved
grafanaplane/oncall/integration.libsonnet Outdated Show resolved Hide resolved
grafanaplane/oncall/integration.libsonnet Outdated Show resolved Hide resolved
grafanaplane/oncall/integration.libsonnet Outdated Show resolved Hide resolved
grafanaplane/oncall/schedule.libsonnet Outdated Show resolved Hide resolved
grafanaplane/oncall/schedule.libsonnet Outdated Show resolved Hide resolved
Copy link
Member

@Duologic Duologic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

grafanaplane/oncall/schedule.libsonnet Outdated Show resolved Hide resolved
@Duologic Duologic changed the title add high-level OnCall interface feat: add high-level OnCall interface Jan 6, 2025
@Duologic Duologic changed the title feat: add high-level OnCall interface feat(grafanaplane): add high-level OnCall interface Jan 6, 2025
@alexander-bauer alexander-bauer merged commit 9e9172e into main Jan 6, 2025
2 checks passed
@alexander-bauer alexander-bauer deleted the oncall-api branch January 6, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants