-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(grafanaplane): add high-level OnCall interface #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duologic
reviewed
Dec 27, 2024
Co-authored-by: Jeroen Op 't Eynde <[email protected]>
I think that we can push adding coverage for |
Duologic
reviewed
Dec 31, 2024
Co-authored-by: Jeroen Op 't Eynde <[email protected]>
Duologic
reviewed
Jan 2, 2025
Co-authored-by: Jeroen Op 't Eynde <[email protected]>
Co-authored-by: Jeroen Op 't Eynde <[email protected]>
Duologic
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Duologic
changed the title
add high-level OnCall interface
feat: add high-level OnCall interface
Jan 6, 2025
Duologic
changed the title
feat: add high-level OnCall interface
feat(grafanaplane): add high-level OnCall interface
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a high-level interface as a subpackage
oncall
for emitting Grafana OnCall resources. This package provides the following resources:This also provides an interface to Escalation objects as "steps."
This also provides an interface to Route objects.
This also provides an interface to OnCallShift resources.